[statistic plugin] Don't generate md5 sum on open document#5528
Merged
Frenzie merged 1 commit intokoreader:masterfrom Oct 26, 2019
Merged
[statistic plugin] Don't generate md5 sum on open document#5528Frenzie merged 1 commit intokoreader:masterfrom
Frenzie merged 1 commit intokoreader:masterfrom
Conversation
Frenzie
reviewed
Oct 24, 2019
|
|
||
| self.data.pages = self.view.document:getPageCount() | ||
| self.data.md5 = self:partialMd5(self.document.file) | ||
| if not self.data.md5 then |
Member
There was a problem hiding this comment.
Should it also check that it's not an empty string?
Contributor
Author
There was a problem hiding this comment.
On initialize self.data.md5 should be nil so we don't need to check that string is empty.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…5528) There is no need to generate a md5 sum for documents that were already opened.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no need to generate a md5 sum for documents that were already opened.