Fix frozen confirmbox when keyboard shown#5452
Merged
poire-z merged 2 commits intokoreader:masterfrom Oct 4, 2019
Merged
Conversation
…doesn't consume event.
Frenzie
reviewed
Oct 4, 2019
frontend/ui/uimanager.lua
Outdated
| checked_widgets[widget] = true | ||
| if widget.widget:handleEvent(event) then return end | ||
| end | ||
| if widget.widget.modal then |
Member
There was a problem hiding this comment.
Seems like it could just be an or?
Contributor
There was a problem hiding this comment.
It could be a or indeed, but I don't mind the split because of the lengthy comments.
But that if might be a elseif. Dunno if a is_always_active might also be a modal, but calling twice handleEvent on a same widget, even if it returns false, might have some side effect (can't think of any right now, but logically, it could).
A or would solve this issue too, so why not :)
This was referenced Nov 4, 2019
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Nov 6, 2019
Frenzie
added a commit
that referenced
this pull request
Nov 6, 2019
Frenzie
added a commit
that referenced
this pull request
Nov 6, 2019
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
…oreader#5574) This reverts commit 513fd80.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see #5415 #4034