Merged
Conversation
Frenzie
commented
Sep 15, 2019
Frenzie
commented
Sep 15, 2019
Frenzie
commented
Sep 15, 2019
Frenzie
commented
Sep 16, 2019
| end | ||
|
|
||
| function ReaderStatus:onEndOfBook() | ||
| if Device:isHapticFeedbackEnabled() then |
Member
Author
There was a problem hiding this comment.
I think it's probably more elegant if this just reads Device:performHapticFeedback("CONTEXT_CLICK").
Member
There was a problem hiding this comment.
You mean fold the cap check inside performHaptic*?
Member
Author
There was a problem hiding this comment.
Exactly. It already defaults as a no-op anyway and this way it just adds a lot of extra boilerplate.
Frenzie
commented
Sep 17, 2019
References <koreader#5374>.
Member
Author
|
Merging now. The API can be adjusted if other platforms require it. |
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
References <koreader#5374>.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #5374.
@pazos This reflects my basic thought process on how to implement this. Most actions wouldn't do anything of course, basically just keyboard & hold. In using performHapticFeedback it would be up to the system whether it wants to do anything with it.