[fix] Makefile: declare all phonies#4819
Merged
Frenzie merged 1 commit intokoreader:masterfrom Mar 19, 2019
Merged
Conversation
It's generally working as expected at the moment because you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Pointed out by https://github.com/mrtazz/checkmake which I ran out of sheer curiosity.
Frenzie
added a commit
to Frenzie/koreader-base
that referenced
this pull request
Mar 21, 2019
It's generally working as expected you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Cf. koreader/koreader#4819 and koreader#871.
Frenzie
added a commit
to koreader/koreader-base
that referenced
this pull request
Mar 21, 2019
It's generally working as expected you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Cf. koreader/koreader#4819 and #871.
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
It's generally working as expected at the moment because you're unlikely to have a file named `clean`. But if you were to create a file named `all` or `clean` you could have a pretty difficult time figuring out why nothing's happening anymore. Pointed out by https://github.com/mrtazz/checkmake which I ran out of sheer curiosity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's generally working as expected at the moment because you're unlikely to have a file named
clean. But if you were to create a file namedallorcleanyou could have a pretty difficult time figuring out why nothing's happening anymore.Pointed out by https://github.com/mrtazz/checkmake which I ran out of sheer curiosity.