Merged
Conversation
the touch_probe_ev_epoch_time quirk. Fix koreader#630 (!)
This is a complete inversion (i.e., it affects Landscape in a potentially highly stupid manner), unlike in Nickel.
Which also allows us to make it take effect right away when toggled from the menu
(init'ing a "trilogy" should set it to true, then nil right before the touch probe, because it's manually applying it).
accelerometer rotation events)
And honor the setting at startup. Fix koreader#4451
Let's see if that helps...
And watch the swap_xy test being the failing one, now, right?
Frenzie
reviewed
Jan 6, 2019
Member
Frenzie
left a comment
There was a problem hiding this comment.
basically lgtm, a couple of minor comments
| hasClipboard = no, | ||
| hasColorScreen = no, | ||
| hasBGRFrameBuffer = no, | ||
| canToggleGSensor = no, |
Member
Author
There was a problem hiding this comment.
The Oasis has one, but it's trickier to toggle, so I went with something different/more accurate ;)
poire-z
reviewed
Jan 6, 2019
| end, | ||
| }, | ||
| require("ui/elements/flash_ui"), | ||
| require("ui/elements/flash_keyboard"), |
Contributor
There was a problem hiding this comment.
I think these are not that eInk specific. But OK if you need to make room, as it's most probably only on eInk that one will want to disable them (even if I disabled them on my Android phone).
Member
Author
There was a problem hiding this comment.
Yeah, I mainly wanted it to be near the "avoid mandatory black flashes" one, even if they're not technically eInk-specific ;).
Member
Author
There was a problem hiding this comment.
The fact that the eInk submenu is never hidden anywhere cinched the deal ;).
User-facing: hide instead of grey-out unsupported menu entries ;).
Move it to a per-platform overload.
concerned. The Forma has software auto-repeat enabled, and that applies to the SleepCover "key", too. Should help re koreader#4457
Because for some reason, I've seomtimes seen sdio_wifi_pwr being loaded, but not the actual WiFi driver...
Member
Author
|
I have no idea why Travis gets triggered all of a sudden? |
mwoz123
pushed a commit
to mwoz123/koreader
that referenced
this pull request
Mar 29, 2020
* Fix the Touch input probe on Trilogy devices that depend on the touch_probe_ev_epoch_time quirk (fix koreader#630) * Expose a "Pageturn button inversion" feature in the Navigation menu (for all devices with keys) (fix koreader#4446) * Allow ignoring the accelerometer on the Forma (Screen > Ignore accelerometer rotation events; also available from the Gesture Manager) (fix koreader#4451) * Fix SleepCover handling on the Forma (fix koreader#4457) * Make isWifiOn a tiny bit more accurate (check the actual WiFi module instead of sdio_wifi_pwr) * Move all flash related Screen options to the eInk submenu
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.