Skip to content

readermenu(fix): override pan gesture from scrolling#2809

Merged
Frenzie merged 1 commit intokoreader:masterfrom
houqp:menu_pan
Apr 24, 2017
Merged

readermenu(fix): override pan gesture from scrolling#2809
Frenzie merged 1 commit intokoreader:masterfrom
houqp:menu_pan

Conversation

@houqp
Copy link
Copy Markdown
Member

@houqp houqp commented Apr 24, 2017

Without this patch, I got into a really frustrating state where swipes at the top only triggers page scrolls and it took me 20 swipes to get the menu out :(

@Frenzie
Copy link
Copy Markdown
Member

Frenzie commented Apr 24, 2017

I wanted to write this on Wednesday, but for me triggering the menu was not an issue. Only that the document also exhibited some undesired panning in the split second prior.

@houqp
Copy link
Copy Markdown
Member Author

houqp commented Apr 24, 2017

Yeah, usually I only got the undesired panning effect. I only ran into this frustrating state once today.

@Frenzie Frenzie merged commit 55ec64a into koreader:master Apr 24, 2017
NiLuJe added a commit to NiLuJe/koreader that referenced this pull request Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants