"All checks have failed" and all the little red "x"s, does that mean the code won't be added or won't work? Is it just a warning for something you are aware of and safely discount? I've been seeing this a lot lately.

What you see under details is more important. There's one check in the unit tests that's currently not working out and needs to be updated, perhaps because of this change. It's to help against inadvertently breaking something.

@Frenzie The failed test in readersearch_spec :

stack traceback:
    spec/front/unit/readersearch_spec.lua:61: in function <spec/front/unit/readersearch_spec.lua:50>

            for i = 1, 5, 1 do
                rolling:gotoPage(i)
                local words = search:searchFromStart("Verona")
                assert(words == nil)
            end

which tests full text search from the beginning of a book to current page for EPUB format. So it's definitely cannot be affected by koreader/koreader-base@3d9bd2a which only changed the scale in PDF/DjVu reflowing.

My bad, I hadn't investigated but the PR said "update crengine" and the
title sounded relevant.

On Tue, Sep 15, 2015 at 1:42 PM, Huang Xin notifications@github.com wrote:

@Frenzie https://github.com/Frenzie The failed test in readersearch_spec
:

stack traceback:
spec/front/unit/readersearch_spec.lua:61: in function <spec/front/unit/readersearch_spec.lua:50>

        for i = 1, 5, 1 do
            rolling:gotoPage(i)
            local words = search:searchFromStart("Verona")
            assert(words == nil)
        end

which tests full text search from the beginning of a book to current page
for EPUB format. So it's definitely cannot be affected by
koreader/koreader-base@3d9bd2a
koreader/koreader-base@3d9bd2a
which only changed the scale in PDF/DjVu reflowing.

—
Reply to this email directly or view it on GitHub
#1637 (comment).

Never mind, I didn't notice that PR had a crengine update which might have something to do with this. Will look into this tonight.