coverimage: only update on rotation if rotate image enabled#15179
Merged
Conversation
Creating the cover image delays rotation a little bit (half a second, even if cached), although it could be several seconds on some PocketBook devices since koreader#14985 which synchronously invokes `sync` after creating the cover. To work around this, skip creating the image in the onSetRotationMode event hook if "Rotate image" is disabled as the resulting image would be exactly the same. The speedup is noticeable even if the cover cache gets hit. (The issue with synchronous `sync` taking several seconds will be fixed later once we figure out whether any PocketBook devices actually need the `sync` or not.) Related: koreader#15177 Related: koreader#14985
3 tasks
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…#15179) Creating the cover image delays rotation a little bit (half a second, even if cached), although it could be several seconds on some PocketBook devices since koreader#14985 which synchronously invokes `sync` after creating the cover. To work around this, skip creating the image in the onSetRotationMode event hook if "Rotate image" is disabled as the resulting image would be exactly the same. The speedup is noticeable even if the cover cache gets hit. (The issue with synchronous `sync` taking several seconds will be fixed later once we figure out whether any PocketBook devices actually need the `sync` or not.) Related: koreader#15177 Related: koreader#14985
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating the cover image delays rotation a little bit (half a second, even if cached), although it could be several seconds on some PocketBook devices since #14985 which synchronously invokes
syncafter creating the cover.To work around this, skip creating the image in the onSetRotationMode event hook if "Rotate image" is disabled as the resulting image would be exactly the same. The speedup is noticeable even if the cover cache gets hit.
The issue with synchronous
synctaking several seconds will be fixed later once we figure out whether any PocketBook devices actually need thesyncor not.See #15177 for details. (Note that this PR doesn't completely fix that issue! It's just a partial workaround and requires disabling "Rotate image".)
This change is