ReaderHighlight: don't try to write page bookmarks into PDF#15097
Merged
Conversation
Frenzie
reviewed
Mar 9, 2026
|
|
||
| function ReaderHighlight:writePdfAnnotation(action, item, content) | ||
| if self.ui.rolling or not self.highlight_write_into_pdf then | ||
| if not (self.document.is_pdf and self.highlight_write_into_pdf and item.drawer) then |
Member
Author
There was a problem hiding this comment.
It is, an existing annotation.
Contributor
There was a problem hiding this comment.
Might be more readable if you had 2 ifs ?
if self.ui.rolling then return end
if [the paging/pdf conditions] then return end
Member
Author
There was a problem hiding this comment.
I think is_pdf is more informative here than rolling/paging.
Frenzie
approved these changes
Mar 9, 2026
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is