fix: import embedded PDF annotations properly#15076
Merged
Merged
Conversation
Fix annotation import to preserve notes, filter by type, deduplicate, map drawer, and delete originals from PDF after import. Closes koreader#15075. Depends on koreader-base#2287.
47fac3e to
dfa9e65
Compare
Member
|
Thanks, good development. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Fix annotation import to preserve notes, filter by type, deduplicate, map drawer, and delete originals from PDF after import. Closes koreader#15075. Depends on koreader-base#2287.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15075. Depends on koreader/koreader-base#2287.
Problems with current import (#15040)
note = "embedded highlight", overwriting actual/ContentsChanges
getEmbeddedAnnotations()wrapper for the new koreader-base function that returns type, boxes, and contents per markup annotationsaveHighlightsFromBoxes()withimportEmbeddedAnnotations():/Contentsas KOReader notehighlight_write_into_pdfnaturally (no more disable/restore hack)This change is