KoptInterface: fix panel zooming when dewatermark is on#15067
Merged
Conversation
Member
Are you referring to not caching some intermediate step or the end result? |
Contributor
Author
|
|
Frenzie
reviewed
Mar 3, 2026
Frenzie
pushed a commit
that referenced
this pull request
Mar 17, 2026
) Due to changes to renderOptimizedPage(...) made by #15067, which was merged after #14954 was made, a regression was introduced that causes instability and even crashes on mobile devices and e-readers when Invert Document is enabled along with Reflow or Auto Straighten. This PR fixes the regression and simplifies the drawContextPage(...) method.
jqs7
pushed a commit
to jqs7/koreader
that referenced
this pull request
Mar 19, 2026
…eader#15123) Due to changes to renderOptimizedPage(...) made by koreader#15067, which was merged after koreader#14954 was made, a regression was introduced that causes instability and even crashes on mobile devices and e-readers when Invert Document is enabled along with Reflow or Auto Straighten. This PR fixes the regression and simplifies the drawContextPage(...) method.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…eader#15123) Due to changes to renderOptimizedPage(...) made by koreader#15067, which was merged after koreader#14954 was made, a regression was introduced that causes instability and even crashes on mobile devices and e-readers when Invert Document is enabled along with Reflow or Auto Straighten. This PR fixes the regression and simplifies the drawContextPage(...) method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, panel zoom does not work when
dewatermarkis on.This PR fixes the issue by calculating and using the correct bbox.
part_tileis not cached yet; I'm not sure if caching is necessary.Tested on Kindle Paperwhite (12th Generation).
This change is