BookStatusWidget: fix impossible to exit review editing due to focus loop#15055
Merged
Conversation
…loop Due to the way this was wired, koreader#14937 trigged BookStatusWidget:onSwitchFocus() when closing, which caused the review input dialog to pop right back up again. But it doesn't look like you're actually supposed to be able to type in there at all, so I replaced it with a TextBoxWidget.
Contributor
|
Fine with me (the onGesture is a bit hackish, but fine for this old clumsy widget). |
Member
Author
|
I didn't immediately see a cleaner solution. I don't much like how that looks but I don't particularly want to spend much time on it either. |
Member
|
Cannot update book status in the Book status window: the Review input dialog is called on tapping on the toggle. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…loop (koreader#15055) Due to the way this was wired, koreader#14937 trigged BookStatusWidget:onSwitchFocus() when closing, which caused the review input dialog to pop right back up again. But it doesn't look like you're actually supposed to be able to type in there at all, so I replaced it with a TextBoxWidget.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way this was wired, #14937 trigged BookStatusWidget:onSwitchFocus() when closing, which caused the review input dialog to pop right back up again.
But it doesn't look like you're actually supposed to be able to type in there at all, so I replaced it with a TextBoxWidget.
This change is