Skip to content

SSH.koplugin: option to force key-only auth#15038

Merged
Frenzie merged 1 commit into
koreader:masterfrom
ge-roy:feature/ssh_keyonly_option
Feb 27, 2026
Merged

SSH.koplugin: option to force key-only auth#15038
Frenzie merged 1 commit into
koreader:masterfrom
ge-roy:feature/ssh_keyonly_option

Conversation

@ge-roy

@ge-roy ge-roy commented Feb 25, 2026

Copy link
Copy Markdown
Contributor

User can enable key-only access to enhance security, useful when using public WiFi networks, and just a good rule even for well-known or home networks.


This change is Reviewable

User can enable key-only access to enhance security,
useful when using public WiFi networks, and just a good rule
even for well-known or home networks.
@ge-roy ge-roy force-pushed the feature/ssh_keyonly_option branch from 6445983 to 73cfecd Compare February 25, 2026 18:26
@ge-roy ge-roy changed the title SSH.koplugin: force key-only auth SSH.koplugin: option to force key-only auth Feb 25, 2026
},
{
text_func = function()
return _("Login with key only (SECURE, public key required)")

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe OpenSSH and Dropbear both call it something like "disable password login". The text needn't necessarily correspond, but that'd make it harder to find documentation about it.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the UI we have already feature related to login process and it's called Login without password (DANGEROUS) so I thought from UX perspective - to have them both similar will just make sense:

ssh_key_only_auth

However I don't have a strong preference on that. I can think of:

  1. Disable password login (SECURE);
  2. Disable password login (SECURE, key required);
  3. Disable password (SECURE);
  4. Disable password (SECURE, key required);
  5. Disable password login (key required);
  6. Disable password (key required);

At the same time Login without password and Disable password can mislead people.

@Frenzie Frenzie added this to the 2026.02 milestone Feb 27, 2026
@Frenzie Frenzie merged commit 0ffe37f into koreader:master Feb 27, 2026
2 checks passed
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
User can enable key-only access to enhance security,
useful when using public WiFi networks, and just a good rule
even for well-known or home networks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants