calibre: use correct callback when Wi-Fi is off at connect time#14998
Merged
Conversation
`self.re` isn't assigned until later in connect() (line 292), so at line 244 it is always nil — either never set, or cleared by a previous disconnect(). This caused willRerunWhenConnected to receive nil as its callback, so after Wi-Fi was brought up the coroutine was never resumed and the Calibre connection silently died. Use the local `re` (defined on line 234) which is the correct resume callback for this coroutine.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
`self.re` isn't assigned until later in connect() (line 292), so at line 244 it is always nil — either never set, or cleared by a previous disconnect(). This caused willRerunWhenConnected to receive nil as its callback, so after Wi-Fi was brought up the coroutine was never resumed and the Calibre connection silently died. Use the local `re` (defined on line 234) which is the correct resume callback for this coroutine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Wi-Fi is off and the user taps "Connect to calibre", the plugin asks NetworkMgr to bring up Wi-Fi and re-run a callback to resume the connection flow. However, the callback passed is
self.re, which isn't assigned until later in the function (line 292). At line 244 it is alwaysnil, either never set, or explicitly cleared by a previousdisconnect().The
nilpropagates silently through the NetworkMgr chain (beforeWifiAction→enableWifi→connectivityCheck) becauseconnectivityCheckguards the callback call withif callback then. The result: Wi-Fi comes up successfully, but the Calibre connection coroutine is never resumed. No error is shown to the user.This change is