CoverImage: fix inconsistent vertical alignment of cover image#14987
Merged
Conversation
Center the scaled cover image on both axes unconditionally instead of branching on which dimension is the limiting factor. The branch was susceptible to floating point rounding in math.floor causing scaled_w to be 1 pixel less than s_w, flipping the alignment from vertically centered to top-aligned depending on the cover's pixel dimensions.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
…der#14987) Center the scaled cover image on both axes unconditionally instead of branching on which dimension is the limiting factor. The branch was susceptible to floating point rounding in math.floor causing scaled_w to be 1 pixel less than s_w, flipping the alignment from vertically centered to top-aligned depending on the cover's pixel dimensions. Fixes koreader#14986.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14986.
Center the scaled cover image on both axes unconditionally instead of branching on which dimension is the limiting factor. When a dimension has no margin,
math.floor(0 / 2)evaluates to 0, so the centering is a no-op on that axis.This change is