Skip to content

Wikipedia EPUBs: use 1.5x image when 2x not available#14984

Merged
poire-z merged 1 commit into
koreader:masterfrom
poire-z:wiki_srcset_1_5x
Feb 15, 2026
Merged

Wikipedia EPUBs: use 1.5x image when 2x not available#14984
poire-z merged 1 commit into
koreader:masterfrom
poire-z:wiki_srcset_1_5x

Conversation

@poire-z

@poire-z poire-z commented Feb 15, 2026

Copy link
Copy Markdown
Contributor

Looks like there are more images with srcset 1.5x than with 2x.


This change is Reviewable

Looks like there are more images with srcset 1.5x than
with 2x.
@poire-z poire-z added this to the 2026.02 milestone Feb 15, 2026

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that still fine with the rest of the width/height logic?

@poire-z

poire-z commented Feb 15, 2026

Copy link
Copy Markdown
Contributor Author

Yes, we rewrite <img...> to include style="width: Wpx; height:Hpx", so crengine will scale them to the original image size - it's just better when later long-press on them to show then in ImageViewer.

@poire-z poire-z merged commit bda24c8 into koreader:master Feb 15, 2026
4 checks passed
@poire-z poire-z deleted the wiki_srcset_1_5x branch February 15, 2026 15:34
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Looks like there are more images with srcset 1.5x than with 2x.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants