[ReaderFooter] Adds a fixed-width setting for progress bar alongside items#14980
Conversation
|
Looks cool! |
|
I like the idea. |
|
Boxes at the top of clusters or your other option is to add a checkbox to the spin widget where one sets the minimum. |
Commodore64user
left a comment
There was a problem hiding this comment.
please move the box to the top.
|
|
|
I said #14980 (comment) keep the two together Lock edit: the entire status bar menu follows one simple rule, Boxes at the top of their clusters. |
|
I'd prefer the current order unchanged. |
|
but I don't, because there is some order now, and I don't want anyone circumventing it. We all know what mess it was like before, so @Frenzie, break the tie |
|
Style |
|
I don't understand what lock would do on top. I'd also make it minimum followed by lock. |
|
The same it would be doing at the bottom ;) plus remaining consistent with the rest of the menu |
This reverts commit e086685.
|
Consistent with what? It's a minor visual detail, not a "show this thing yes or no" setting. |
|
That's the problem exactly, cumulative "minor" things make a big thing. I thought you were built differently ;) do you think S. Jobs would have said the same? I doubt it |
|
I'm not entirely sure if you're just joking but I mean the setting toggles a minor visual subdetail that is dependent on the other setting that should therefore logically be above it, which is different in kind from the checkboxes you're referring to. Checkboxes shouldn't come first because they're checkboxes. They merely frequently come first because of what they do. |
|
PS Does the width dialog support adding a checkbox at the bottom of it? It doesn't necessarily need to be in the menu at all. |
|
I was looking at that when I first started, but I couldn't find any example of a single spin-widget with a checkbox underneath. Also, I don't really like the idea of having to go one further level down to toggle this. |
|
Alright. |
|
What if we move up the separator:
|
|
It looks fine graphically, but it doesn't seem to make much sense in regard to the underlying meaning. I'll merge it as is for this release. |
Well, I was asked to break the tie after all. Sorry. :-)
…items (koreader#14980) Also increased the available range for the minimum width in the UI from 50% of the screen width to 90%, since with the fixed setting it could otherwise never get larger than 50%, but a wider size will be useful if only few and short items fill up less than 50% of the remaining space.
Added a Fixed-width setting for the progress bar, available when displayed alongside the text items.
Without fixed width setting the progress bar size can vary widely, making the tracking of one's position more difficult :
dynamic.mp4
With fixed with setting (new):
fixed.mp4
I also increased the available range for the minimum width in the UI from 50% of the screen width to 90%, since with the fixed setting it could otherwise never get larger than 50%, but a wider size will be useful if only few and short items fill up less than 50% of the remaining space.
This change is