newsdownloader: fix url path separator encoding bug#14975
Merged
Frenzie merged 1 commit intoFeb 14, 2026
Conversation
Member
|
Also with reference to #14718 |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
The url encoding that was implemented in #14870 encoded
/as%2F. This leads to broken processing of feeds and articles that contain a sub path like https://github.com/koreader/koreader/releases.atom -> https://github.com%2Fkoreader%2Fkoreader%2Freleases.atom.Fix
Preserve path separators and existing percent-encoded octets during path normalization in NewsDownloader, while still encoding invalid path characters (e.g. spaces).
Tests: added regression tests in
newsdownloader_url_normalization_spec.luathat can be run on future changes to the url normalization.This change is