Stable pages in file browser 3#14952
Merged
Merged
Conversation
Contributor
|
No real opinion either (but not really grasping what the linked issues are about). (%T being used for title, would have been nice to have balanced lowercase/uppercase for the different behaviours) |
Member
Author
|
Patterns |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Patterns %c (current page) and %t (total pages) will show the same values in reader and file browser.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes "total pages" and "current page" patterns in the file browser when stable pages enabled.
Currently the index of the label is shown as "current page" (based on the percent finished and the quantity of labels).
#14933 asks to show the label itself, this would require saving it to sdr on document closing.
I don't have the strong opinion on this request.
This change is