[Pocketbook] Execute rotation fix also for Era Color#14904
Conversation
| -- c.f., https://github.com/koreader/koreader/issues/11033 | ||
| if self.device.model == "PB700" then | ||
| logger.dbg("afterResume: Running orientation sync for PB700") | ||
| if self.device.model == "PB700" or self.device.model == "PBEraColor" then |
There was a problem hiding this comment.
Do we know if the issue is limited to a very small number of devices only? Otherwise it should probably become something like needsOrientationSyncAfterResume (quite a mouthful).
There was a problem hiding this comment.
According to the devices mentioned in the bug it is related to:
- Pocketbook Era
- Pocketbook Era Color
- Some Pocketbook Inkpad Color (I don't know which, there are seven models that are supported by KOReader)
I agree that the model-specific property might be better, let me try to incorporate that
There was a problem hiding this comment.
That's very simple, just add it to the global device definition with = no, with = yes on those devices, and in this file it'll be something like if self.device:needsScreenOrientationSync….
There was a problem hiding this comment.
I think having it on the Pocketbook definition is already suficient, isn't it?
I implemented this approach with d66e1d4
There was a problem hiding this comment.
Yes, but in that case please make it needs_orientation_sync_after_resume (or use yes and no and use it as a function).
There was a problem hiding this comment.
Ah no, I must've been unclear. camelCase is a function, snake_case is a variable.
There was a problem hiding this comment.
No worries, I can adapt it :)
Do you have a preference for a way?
There was a problem hiding this comment.
Like I said, I don't really care, just don't mix & match so the code remains clear. On average we prefer a function (because that can be overridden to do something slightly fancier on a particular device if need be) but in this case let's just use a variable.
|
I tested out the new nightly late last night and it does indeed seem to have completely fixed the issue on my Era Color, thank you so much!! |
@theboomr reported [here](koreader#11033 (comment)), that the rotation issue koreader#11033 is also affecting the Pocketbook Era Color.
@theboomr reported here, that the rotation issue #11033 is also affecting the Pocketbook Era Color.
Apparently the PB Inkpad Color is also affected, however since I don't know which of the versions this would be I would wait for someone to report/fix the issue there to not cause regressions for unaffected devices.
This change is