Skip to content

fix(calibre-plugin): ensure size is correctly parsed as a number in book info in search#14881

Merged
Frenzie merged 3 commits into
koreader:masterfrom
CamilleHbp:master
Mar 8, 2026
Merged

fix(calibre-plugin): ensure size is correctly parsed as a number in book info in search#14881
Frenzie merged 3 commits into
koreader:masterfrom
CamilleHbp:master

Conversation

@CamilleHbp

@CamilleHbp CamilleHbp commented Jan 25, 2026

Copy link
Copy Markdown
Contributor

This function was causing a crash on koreader if a value was nil. It happened to me multiple times over the last few months when using calibre with fanfictions, which alter book files when updating.

Here is a simple fix to prevent the crash by parsing before accessing the value.


This change is Reviewable

Comment thread plugins/calibre.koplugin/search.lua Outdated
@hius07 hius07 added the Plugin label Jan 25, 2026

@hius07 hius07 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Frenzie Frenzie added this to the 2026.01 milestone Jan 25, 2026
Comment thread plugins/calibre.koplugin/search.lua Outdated
@Frenzie Frenzie merged commit 2cef437 into koreader:master Mar 8, 2026
1 of 2 checks passed
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants