Skip to content

[ReaderDictionary] clean stress marks from selection for dict search#14856

Merged
Frenzie merged 1 commit into
koreader:masterfrom
Commodore64user:stress-marks
Jan 27, 2026
Merged

[ReaderDictionary] clean stress marks from selection for dict search#14856
Frenzie merged 1 commit into
koreader:masterfrom
Commodore64user:stress-marks

Conversation

@Commodore64user

@Commodore64user Commodore64user commented Jan 20, 2026

Copy link
Copy Markdown
Member

what's new

  • Improved text cleaning in ReaderDictionary:cleanSelection by stripping the primary (ˈ) and secondary (ˌ) stress marks commonly found in phonetic transcriptions.


This change is Reviewable

@Frenzie Frenzie added this to the 2026.01 milestone Jan 20, 2026
@jonnyl2

jonnyl2 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Aren't these marks only used for the word in the article you're already on? When would you need this for a new search?

@Commodore64user

Commodore64user commented Jan 20, 2026

Copy link
Copy Markdown
Member Author

not sure what your concern is exactly @jonnyl2, multiple dictionaries have different entries, for example Collins has an entry for "stratum" that has the noun "stratal" which has it's own separate entry in the OED. A man is free to search multiple dicts.

Also, many OED headwords have stress marks as well, many a time have I also needed to search the headword again.

Screenshot 2026-01-20 at 21 36 10

I will now take this time to shamelessly plug the oed_prettifier mainly because instead of focusing your energy on questioning whether stress marks should remain or go, you could be helping make a better OED for all. I need people to report issues they encounter, I can't do it alone.
Tangentially, my friend sent me a screenshot the other day in which he asked Gemini what the oed_prettifier was... Gemini said, and I quote here: "It's a niche tool for bibliophiles" ouch.

@jonnyl2

jonnyl2 commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

It's alright, I've just never encountered them in years of KOReader dictionary use (but then again, I don't use the OED or other fancy dictionaries -- maybe I'm not bibliophile enough). But I'll take a look at your project, since you asked nicely.

@Frenzie

Frenzie commented Jan 20, 2026

Copy link
Copy Markdown
Member

They occur plenty in my paper dictionaries in any case.

@Commodore64user

Copy link
Copy Markdown
Member Author

seven days... 🎉

@Frenzie Frenzie merged commit cd49bf3 into koreader:master Jan 27, 2026
4 checks passed
@Commodore64user Commodore64user deleted the stress-marks branch January 27, 2026 13:25
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants