ReaderBookmark: color in bookmark list#14714
Conversation
| end, | ||
| }, | ||
| { | ||
| text = _("Include 'gray'"), |
There was a problem hiding this comment.
This means whether or not you get a choice of colors on a b&w device?
| if bookmarks_items_show_color then | ||
| if item.color == nil or item.color == "gray" then | ||
| if bookmarks_items_show_gray then |
There was a problem hiding this comment.
Is "gray" our default everywhere ? On my emulator, I get my highlights in yellow since a few months ago. I don't remember having done anything special to get them yellow (?).
|
"Include 'gray'" will be changed to "Include default color". |
|
The thing I'm not happy with is unaligned right edge of the colored rectangles, depending on the mandatory length. |
Might it make more sense to just stick the regular star indicator in there? Or do you mean change to something completely custom. |
|
The default highlight color is set in the Typeset - Highlights menu, and the star is already there. The new option use case: most highlights are in the default color, and only a few are in red. |
|
| text = _("Show highlight colors"), | ||
| checked_func = function() | ||
| return G_reader_settings:isTrue("bookmarks_items_show_color") | ||
| end, | ||
| callback = function() | ||
| G_reader_settings:flipNilOrFalse("bookmarks_items_show_color") | ||
| end, | ||
| }, | ||
| { | ||
| text = _("Include default highlight color"), |
There was a problem hiding this comment.
To my non-native English ears & eyes, the use of "Include" here feels odd.
No obvious alternative suggestion :/
In the past, I've used "Also..." (which feels odd re-reading these :)) when I had no better idea (at least one of these must be mine):
frontend/apps/filemanager/filemanagerfilesearcher.lua: text = _("Also search in book metadata"),
frontend/apps/filemanager/filemanagercollection.lua: text = _("Also search in book content (slow)"),
frontend/ui/elements/common_settings_menu_table.lua: text = _("Also show values in pixels"),
plugins/statistics.koplugin/main.lua: text = _("Also use in calendar view"),
so I would have used "[ ] Also show default highlight color".
There was a problem hiding this comment.
I think "also show" would be clearer regardless if it's odd or not. But perhaps that's what you meant. :-)
Introducing colored text in the Menu widget.
An option in settings to show color in the Bookmark list.
Filter bookmarks by highlight color.
This change is