rename file_cap to max_files#14522
Merged
Merged
Conversation
Member
|
I'll wait for @poire-z but to me this seems to reduce clarity. It's not a file count but a file iteration cap/limit (or just number). |
Contributor
|
Fine with me, It's better with having "count" than the previous file_cap. |
Member
|
Such a variable is normally named max_files or file_limit (search GitHub code). |
Member
|
max_files in util, and screensaver_random_max_files look good. |
Member
Author
|
hey @Frenzie will there be a 2025.10, or should we embrace the idea of 2025.11 already? |
Member
|
Barring unforeseen circumstances there will be. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's new
file_capparameter and associated variables tofile_count_capfor clearer intent (even though the poet already knows what the word cap means). ;)@poire-z might need to merge this ASAP
This change is