ReaderHandMade: fix handmade hidden flow starting from page 1#14502
Merged
Conversation
Frenzie
approved these changes
Oct 25, 2025
| local last_linear_page = nb_pages | ||
| if #flows > 0 then | ||
| local flow = flows[1] | ||
| if flow[1] == 1 then -- book first page is in a hidden flow |
Member
There was a problem hiding this comment.
Shouldn’t this be: “the book’s first page is in a hidden flow”?
Contributor
There was a problem hiding this comment.
I might also have written it like this in native american's English :) but if this reads better, why not.
Member
There was a problem hiding this comment.
Shouldn’t this be: “the book’s first page is in a hidden flow”?
It should probably be "the first page of the book," if you're nitpicking. ;-)
But instead I'd just drop the "book."
(No need; I'm not nitpicking here.)
poire-z
approved these changes
Oct 27, 2025
poire-z
left a comment
Contributor
There was a problem hiding this comment.
No longer familiar with my code about fist/last_linear_page , and hard to grasp.
You code reads fine and simpler, so I guess it's ok. Anyway, trusting you.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is