Book info: more informative Pages infomessage#14493
Conversation
|
To fully explain Publisher and Screen pages (as requested by @poire-z), I'd suggest adding these two extra lines: Publisher pages: Screen pages: Is the previous information with publisher page source info and first and last page labels still accessible? I'm only getting the above now on short tap, and long-press has no effect. |
It's in the menu Stable page numbers - Publisher page numbers source info. |
|
I think it could be added at the bottom of this help screen as well? It should all fit on one 6" screen. |
|
I agree with the above suggestions, the more info the better, this InfoMessage has room and is called on purpose to get that more info. |
|
|
"total" feels a a bit odd in "Screen pages total:", no? |
|
It's instead of "including hidden flows". |
|
"Total screen pages" should sound more natural. Was there an objection to "including hidden flows"? |
This wording makes sense only when there are hidden flows and there is a discrepancy between the status bar and the book info window. "Total screen pages" is neutral and can be used in any case. |
|
Alright. |
|
Optimized 'Screen pages' info, can mention hidden flows when available. 
|
| if self.is_current_doc and self.ui.pagemap and self.ui.pagemap.has_pagemap then | ||
| local t = {} | ||
| local screen_pages = _("Screen pages") .. ":\n" .. pages | ||
| if self.document:hasHiddenFlows() then | ||
| screen_pages = screen_pages .. " " .. _("(including hidden flows)") |
There was a problem hiding this comment.
I guess we could have "(including hidden flows)" even when no has_pagemap ?
There was a problem hiding this comment.
We do not show this infomessage on tap when there is no pagemap.
There was a problem hiding this comment.
But yes, I see, we can show it just in the bookinfo table.
There was a problem hiding this comment.
Unfortunately no, the line in the bookinfo table is short, there is no room for "(including hidden flows)" when has_pagemap.
There was a problem hiding this comment.
I'd say: keep it short in Bookinfo in all cases. And show the popup with words in all cases (even if it doesn't say much more). For consistency.
Addresses #14473 (comment).
This change is