HTMLBoxWidget: add setRawContent()#14480
Merged
Merged
Conversation
Contributor
|
|
Member
Author
|
Perhaps just naming it better does indeed make it seem less redundant to offer it as a separate method. |
poire-z
reviewed
Oct 19, 2025
poire-z
approved these changes
Oct 19, 2025
Member
Author
|
For context, I'm playing around auto-generating a little weather SVG (obviously very work in progress, not intended for inclusion here but I intend to share it on contrib once it's a bit less of an ugly POC). I briefly experimented with doing it in KOReader UI, but ultimately it seems simpler to combine all of the parts within SVG itself. On the right is crengine for comparison. It seems to maintain some kind of margins despite setting them to 0. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The functionality I'm looking for is really just a way to pass through the pure string without any of the current manipulation in setContent (which would sometimes be good for HTML too) and maybe a custom "magic", but I'm not quite seeing an elegant way to do that right now.
This change is