You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I see you kept your changes (about events) in the other files, they are still good without what we revert ?
I also see you kept a few pagemap related stuff in getCurrentStat() - I guess this is supposed to show some valid info using ref/synth page numbers in the Current book statistics ?
Is that enough to please @ReneeIbeji and the like, which was I think the initial wish that initiated the original PR that we are reverting ?
Do you think there are other places in statistics that we should look at later, and where we may adapt the arithmetic (using iteration of pagemap/pagelabels for example) ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So, revert storing reference pages in the statistics database, back to screen pages.
This change is