Skip to content

Statistics: screen pages only#14435

Merged
hius07 merged 1 commit into
koreader:masterfrom
hius07:stats-ref-pages
Oct 10, 2025
Merged

Statistics: screen pages only#14435
hius07 merged 1 commit into
koreader:masterfrom
hius07:stats-ref-pages

Conversation

@hius07

@hius07 hius07 commented Oct 9, 2025

Copy link
Copy Markdown
Member

So, revert storing reference pages in the statistics database, back to screen pages.


This change is Reviewable

@hius07 hius07 added the Plugin label Oct 9, 2025
@poire-z

poire-z commented Oct 9, 2025

Copy link
Copy Markdown
Contributor

Thanks.

I see you kept your changes (about events) in the other files, they are still good without what we revert ?

I also see you kept a few pagemap related stuff in getCurrentStat() - I guess this is supposed to show some valid info using ref/synth page numbers in the Current book statistics ?
Is that enough to please @ReneeIbeji and the like, which was I think the initial wish that initiated the original PR that we are reverting ?
Do you think there are other places in statistics that we should look at later, and where we may adapt the arithmetic (using iteration of pagemap/pagelabels for example) ?

@hius07

hius07 commented Oct 9, 2025

Copy link
Copy Markdown
Member Author

I think the event is good, currently remains 3 handlers.

"Current page / total pages" string in the Current book statistics is the same as in the status bar.

I didn't find any more places in the statistics where reference page labels or indexes could be used.

@hius07 hius07 merged commit e84d63b into koreader:master Oct 10, 2025
4 checks passed
@hius07 hius07 deleted the stats-ref-pages branch October 10, 2025 19:22
@hius07 hius07 added this to the 2025.10 milestone Oct 10, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants