Skip to content

fix: Corrected AutoSuspend logic for Kindles#14430

Merged
Frenzie merged 3 commits into
koreader:masterfrom
DemonicSavage:input-event
Oct 10, 2025
Merged

fix: Corrected AutoSuspend logic for Kindles#14430
Frenzie merged 3 commits into
koreader:masterfrom
DemonicSavage:input-event

Conversation

@DemonicSavage

@DemonicSavage DemonicSavage commented Oct 7, 2025

Copy link
Copy Markdown
Contributor

This fixes #14428. Previously, the logic was backwards and PowerD:resetT1Timeout() was never called, so Kindle OS's timer triggered suspends when it shouldn't.


This change is Reviewable

@mergen3107

Copy link
Copy Markdown
Contributor

Huh, thank you!
I suppose that will fix #7874 for real now :D

@mergen3107

Copy link
Copy Markdown
Contributor

@NiLuJe
Our Kindle guru
Could you please review this PR?

@Frenzie

Frenzie commented Oct 8, 2025

Copy link
Copy Markdown
Member

It's just basic logic, not really about Kindle. :-)

Comment thread plugins/autosuspend.koplugin/main.lua Outdated
@Frenzie Frenzie added the Kindle label Oct 8, 2025
@Frenzie Frenzie added this to the 2025.10 milestone Oct 8, 2025
@DemonicSavage

Copy link
Copy Markdown
Contributor Author

Recent Kindle firmware lets you customize the autosuspend timer, the minimum being 5 minutes. I'm wondering if we should lower default_kindle_t1_timeout_reset_seconds to account for that.

@Frenzie

Frenzie commented Oct 8, 2025

Copy link
Copy Markdown
Member

I think the main thing we want to prevent is that it runs constantly. If it runs every ~4 minutes instead of every ~5 minutes I'm sure that should be fine.

This is to account for an edge case where a Kindle might be set to autosuspend in 5 minutes instead of the standard 10.

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ping me in a few days if I forget. ;-) I'll wait a few days to see if @NiLuJe has time to respond.

@Frenzie Frenzie merged commit 48a3954 into koreader:master Oct 10, 2025
4 checks passed
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

HTTP Inspector events don't prevent auto suspend from triggering on Kindle devices

3 participants