OPDS: fix Search#14425
Merged
Merged
Conversation
Frenzie
reviewed
Oct 6, 2025
Comment on lines
+783
to
+784
| item_url = item_url:gsub("%%s", function() return search_str end) | ||
| self:updateCatalog(item_url) |
Member
There was a problem hiding this comment.
Fwiw I think we tend to use socket.skip(), or at least a bunch of the code does. (Not an expression for any preference.)
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #14248.
The second result of
gsub(total number of substitutions made) was passed as the second arg tokoreader/plugins/opds.koplugin/opdsbrowser.lua
Line 714 in 7c677bf
This change is