[DocSettingTweak] Use absolute path for document settings#14418
Conversation
External plugins that load files may load them using relative paths instead of absolute paths. This enables these plugins to make use of the per-directory document settings feature.
525a501 to
f1559a0
Compare
|
This fixes this issue with Rakuyomi. I made a PR there as well, but a) the main dev seems quite sporadically active and b) I think this is a better solution, as it potentially fixes other plugins that may do the same thing. |
|
@yparitcher Do you know if there could be any side effects? |
|
Yes, The plugin is now agnostic to relative or absolute paths, both should work, we just follow whatever we are given, we also set the This should be changed in the plugin to match the rest of koreader, as i am sure that this is not the only place breaking, and this is for sure not the root cause. |
|
That makes sense. I have changed it to normalize the path in ReaderUI instead. |
|
What is the status on this? It's slated for 2025.10, does that mean it will be merged before that? Or is it missing something? I'm sorry for such a basic question as this is my first time contributing to open source stuff that's not just me. |
|
In this project, the approved and 2025.10 are notes to myself and others. We used to just do that in writing to roughly the same effect before GitHub added the feature, but this way you see it nicely in the overview and you can sort and filter on it in the list. The approved so that I know who looked at it already and found it fine, the 2025.10 so that I can quickly find it when looking for things that should still be merged. But only after there have been at least a few days for other people to comment if they want, unless it's some small or very obvious thing. (This PR doesn't qualify as obvious.) But it's not typically a 2025.10 in the sense that it has to be finished or merged before a release happens, which may be the case for other projects. It's an indication that I'd like it to be in or that I expect it'll be ready in time. |
…4418) External plugins that load files may load them using relative paths instead of absolute paths. This enables these plugins to make use of the per-directory document settings feature.
External plugins that load files may load them using relative paths instead of absolute paths. This PR enables these plugins to make use of the per-directory document settings feature.
This change is