Profiles: auto exec promptly#14133
Conversation
Frenzie
left a comment
There was a problem hiding this comment.
I'm not quite sure of the name but I'm currently drawing a blank on other ideas.
|
I thought about "earlier", but earlier than what? |
|
Execute promptly @offset-torque, proposition for the User guide. (Minor mistake in the guide: Combined with book is being opened for the first time is not applicable to the "on book closing" trigger) UPDATED HELP TEXT: |
|
Though mind that slight delay can probably be measured in sub-microseconds most of the time, correct? |
|
Feels a bit quite technical, and I'm not sure a normal (even if power-)user would know when to enable this or not. |
|
I'm afraid some conflicts may appear depending on the profile actions. Generally, I would always try to auto-execute with this feature enabled, and to disable it when execution fails only. |
Wouldn't it then make more sense to have prompt execution as the default behavior, and have a checkbox for "Execute with a slight delay (to avoid conflicts)" (or similar phrasing) as an option? |
|
Yes, if it's intended as the default it can be disabled and say something like I wouldn't speak of delay if it can be avoided since next tick isn't a delay in human terms. |
|
This may cause an increasing number of questions "My auto-exec fails, what should I do" and our answers "Enable the checkbox". Writing "I would always..." I meant an expirienced user. |
|
UPDATED HELP TEXT: |
|
Let's also as a hold callback. |
|
Okay, waiting for @offset-torque 's comments. |
|
Just some clarifications:
From this text I understand this (from the POV of a normal user):
Are these correct? As a problem, first thing that comes to my mind is same as what poire-z said:
So for this option, I guess we (devs) too don't know the exact problematic conditions that might arise. So basically we are telling the users this: And a question: Currently there are no other troubleshooting steps for profiles except this, right? |
Just the opposite. Enabling this new checkbox allows using some actions, like exporting highlights on document closing. So I propose to not change the default state of things, and to have an option to enable (or to try to enable) some combinations of trigger/condition/actions, on the user's own risk. Finally, "if your profile fails, try to enable this new option. If it fails again (maybe in the other way), your profile cannot be auto-executed, report it to us, and we will think again". |
|
Got it. I added this to my task list hius07. When I write the update based on your replies, we will clarify it with your feedback then. |
|
one of my issues with profiles and status bar presets, is that they [presets] don't get applied when closing a book, I wonder if this will do it... |
|
Yes, it will. Final recommended wording for the User Guide: |
| end, | ||
| }, | ||
| { | ||
| text = _("Execute promptly"), |
There was a problem hiding this comment.
could be something like "Pre-event execution" or "Execute before event action"
Noted |
|
had this crash while closing a book with "execute promptly" |
|
What is the action? |
|
I see, "Load preset". It doesn't depend on "Execute promptly", but on "Partial rendering" (the document is closed on rerendering). Thanks, I shall dig into it. |
it's a a profile, that has one single action, it loads a status bar preset. |
|
"Execute promptly" is enabled "Execute promptly" is disabled By the way, no crash for PDF with "Execute promptly" enabled. I'm afraid this cannot be fixed due to the program architecture. |
Profiles are auto-executed in a safe way: within
nextTick()or eventickAfterNext(), to avoid interference with other operations/events.But sometimes (e.g. on closing a document) a user needs to execute it promtly, provided there are no conflicts with other actions.
Closes #14126.
This change is