Merged
Conversation
hius07
reviewed
Jul 30, 2025
Member
|
Looks good. |
Frenzie
approved these changes
Jul 30, 2025
Member
It would seem I added one of those but I can't remember why. 🤔 Presumably I simply copied it from another part of the code. |
NiLuJe
approved these changes
Jul 30, 2025
NiLuJe
left a comment
Member
There was a problem hiding this comment.
Reviewed 4 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @hius07)
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While fixing 83c27f1 I found the logic in the
touchmenucode has some room for improvement.This is my proposal for a more readable and structured code.
Also, drop the superfluous checks if something named
xxx_funcis really a function. (If it would not be a function, I would consider this a typo)This change is