Skip to content

kodev: use LLDB for debugging on macOS#14072

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/use_lldb_for_macos_debugging
Jul 20, 2025
Merged

kodev: use LLDB for debugging on macOS#14072
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/use_lldb_for_macos_debugging

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Jul 20, 2025

Copy link
Copy Markdown
Member

This change is Reviewable

@benoit-pierre benoit-pierre requested a review from Frenzie as a code owner July 20, 2025 12:59
@Frenzie Frenzie added this to the 2025.06 milestone Jul 20, 2025
@Frenzie Frenzie merged commit ac03e9c into koreader:master Jul 20, 2025
4 checks passed
@benoit-pierre benoit-pierre deleted the pr/use_lldb_for_macos_debugging branch July 22, 2025 16:53
Comment thread kodev
# - GDB standard CLI has a fallback
if ! wrap=("$(command -v ddd cgdb gdb | head -n1)"); then
die 1 "Couldn't find GDB."
if is_system macOS; then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is_system does a die when not on the OS being checked for.

koreader/kodev

Lines 98 to 107 in d3c5ee3

is_system() {
if ! case "$1" in
Linux) [[ "${OSTYPE}" = linux* ]] ;;
macOS) [[ "${OSTYPE}" = darwin* ]] ;;
Windows) [[ "${OSTYPE}" == 'cygwin' || "${OSTYPE}" == 'msys' ]] ;;
*) false ;;
esac then
die 1 "You need a $1 system to build this package"
fi
}

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants