Skip to content

ReaderHighlight: fix long-pressing on image#14048

Merged
hius07 merged 2 commits into
koreader:masterfrom
hius07:hl-fix-hold
Jul 12, 2025
Merged

ReaderHighlight: fix long-pressing on image#14048
hius07 merged 2 commits into
koreader:masterfrom
hius07:hl-fix-hold

Conversation

@hius07

@hius07 hius07 commented Jul 12, 2025

Copy link
Copy Markdown
Member

Fix a bug caused by #14004: after long-pressing on an image, taps don't work until long-pressing on text.


This change is Reviewable

@hius07 hius07 added this to the 2025.06 milestone Jul 12, 2025

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if that's a comment @poire-z might like to keep though.

@poire-z

poire-z commented Jul 12, 2025

Copy link
Copy Markdown
Contributor

Thanks for caring :) We could just keep it that way:
with_title_bar = false, -- more room for image

@hius07 hius07 merged commit c4c95a0 into koreader:master Jul 12, 2025
4 checks passed
@hius07 hius07 deleted the hl-fix-hold branch July 12, 2025 17:29
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants