Moving download all and remove all buttons in OPDS download menu#14024
Conversation
| title_bar_fm_style = true, | ||
| onMenuSelect = self.showDownloadListItemDialog, | ||
| _manager = self, | ||
| title_bar_left_icon = "plus", |
There was a problem hiding this comment.
I think, the "menu" icon is more appropriate here.
Also, as I wrote regarding the server list window, in the root catalog - "menu", in subcatalogs - "plus".
| title_bar_left_icon = "plus", | ||
| onLeftButtonTap = function() | ||
| self:showDownloadListMenu() | ||
| end |
|
What do you think about the buttons order in the new menu? |
|
My thought was that the more commonly used item (download) should be closer to the center of the screen. I think there's an argument that user's finger will be nearest the top to open this menu so the download button would be closer, but I feel my use case would have my finger drift back towards the center personally |
|
You can put all the menu in the center, not anchored. |
(The question was not about where to put most used menu items, center or right: we already made that decision: to the right :) (thinking about right handed people using the device with one hand). It was about what are the most often used items, so they can be put on the right.) |
|
How do we feel about this |
|
I think that the button labels are clear and do not need any description. |
|
My main concern was the size, yeah. I can revert to the original and switch the order no problem! |
|
I could also leave it as above and have no text, if that would be more appealing |
| self:showDownloads(item) | ||
| else -- catalog or Search item | ||
| self.title_bar_left_icon = "plus" | ||
| Menu.init(self) |
There was a problem hiding this comment.
It's expensive, we have setTitleBarLeftIcon method.
| self.item_table[1].mandatory = #self.downloads | ||
| self:updateItems(1, true) | ||
| end | ||
| self:init() |
| }) | ||
| end | ||
| self:switchItemTable(self.catalog_title, menu_table) | ||
| Menu.setTitleBarLeftIcon(self, "plus") |
There was a problem hiding this comment.
Usual notation with self: should work I think.
| self.root_catalog_password = item.password | ||
| self.root_catalog_raw_names = item.raw_names | ||
| end | ||
| -- UIManager:forceRePaint() |
As discussed in #13946
Adds button in download list to do download all and remove all. Currently, both options remain when selecting individual books. I think it should be completely moved to the top left but I understand there being a reason for wanting to keep it where it is and duplicate.
This change is