I've tested on my Kobo, there it works

I'm not entirely sure if that makes sense in the context of the rest of the code. I think that everywhere else it's path .. "/" .. filename where it's used. What do you think @hius07?

Usually we store dir paths without the trailing slash.

In that case @harmtemolder would you mind changing it to add the / in the concatenation where it's used? Sorry to bother you but then it's congruent with code elsewhere and we can also avoid adding a whole migration. :-)

Sure thing. I'm all for staying congruent with code elsewhere. We still need the migration though, because when using the default before (instead of manually selecting a directory) this would include the trailing slash.

I believe I've now rewritten everything to not store trailing slashes in settings, and to concatenate it in when using self.directory or self.archive_directory. I'm testing that now.

We still need the migration though, because when using the default before (instead of manually selecting a directory) this would include the trailing slash.

Unlike the reverse I don't think that's actually problematic other than looking a bit silly? Don't just take my word for it of course, but:

$ touch bla
$ mkdir lala
$ mv bla lala///bla
$ cd lala/
$ ls
bla

I found ffi/util.joinPath() and noticed that ffi/util was already used in main.lua, so figured it would be cleanest to use that. So:

• From now on manually set self.directory or self.archive_directory will not have a trailing slash.
• From now on the default self.archive_directory will not have a trailing slash. (self.directory does not have a default.)
• Users that still have either with a trailing slash in their settings will not notice any change, because ffi/util.joinPath() handles both cases.

And no migration is needed.