close keyboard after calling search with preset#13976
Merged
Merged
Conversation
Member
|
After creating a new preset, the text of the first menu item is changed to the default value. koreader/frontend/ui/presets.lua Line 183 in c456d18 by passing args. The same with Rename preset. |
hius07
approved these changes
Jun 23, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what did I miss
frontend/apps/reader/modules/readerdictionary.lua: Added a call toonCloseKeyboardfordictionary_lookup_dialogto close the keyboard when calling Search with preset.frontend/ui/widget/dictquicklookup.lua: Added a call toonCloseKeyboardforinput_dialogto close the keyboard when calling Search with preset.In my defence, during my extensive testing, using exclusively the keyboard (mouse does not work on emulator), I always had to press esc which would always close the keyboard, oh well.
This change is