ReadCollection: minor speedup#13958
Merged
Merged
Conversation
Frenzie
approved these changes
Jun 16, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Connected folders:
-if a user has entered file types to be added to a collection, do not call
hasProvider;-parse file types string (that can contain several comma separated types) out of the
lfs.dirloop.(2) Adding a book to several collections: call
lfs.attributesonly once.Interesting collection connecting/sorting speed measurement in
https://www.mobileread.com/forums/showthread.php?p=4517852#post4517852
and the following comments.
This change is