[Hotkeys] remove alphabetic hotkeys from K4#13950
Merged
Merged
Conversation
Member
|
That's possibly a bit too smart (or not smart enough), saving a few bytes at the expense of e.g. BT keyboards? |
Member
Author
|
If a device doesn't have a keyboard, hotkeys will not run therefore defaults will not be set. They should only run once there is a keyboard connected thus, no problem? |
Member
|
There's indeed no problem if it runs once connected. |
Member
Author
|
Since you’re in such merging spirit, would you have a look at all these little ones @Frenzie |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's new
defaultsto check for the presence of a keyboard before enabling their functionalities (dictionary_lookup,file_search,wikipedia_lookup, andfulltext_search).This change is