[ReaderHighlight] NT: add key event to simulate a very long press#13914
Merged
Conversation
Frenzie
approved these changes
Jun 9, 2025
Member
Author
|
last minute addition to allow multiple highlights and performing dict lookups on already highlighted words. |
Member
Author
|
Any comments? |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
what's new
On touch devices, it is possible to do a very long press (usually three seconds) on a selection, which brings up the
_highlight_buttonsdialogue. On non-touch devices, this is obviously not possible in the same way, so we now use press for the main action (normal highlight as seen in the screen recording), and shift/screenkb + press to call said dialogue.registerKeyEvents()to unify handling for devices with physical keyboards and screen keyboards by introducing amodifiervariable. This simplifies the logic for assigning key events for text selection.onHighlightModifierPress()method to simulate a long-press action using the modifier key, enabling long-press dialogs during text selection.screen recording
This change is