Skip to content

ButtonDialog: add widgets#13893

Merged
hius07 merged 2 commits into
koreader:masterfrom
hius07:button-dialog-add-widget
Jun 1, 2025
Merged

ButtonDialog: add widgets#13893
hius07 merged 2 commits into
koreader:masterfrom
hius07:button-dialog-add-widget

Conversation

@hius07

@hius07 hius07 commented May 30, 2025

Copy link
Copy Markdown
Member

Will be used, for example, in multiple-choice dialogs:

1


This change is Reviewable

@Frenzie Frenzie added this to the 2025.05 milestone May 30, 2025
@hius07 hius07 merged commit 521401c into koreader:master Jun 1, 2025
4 checks passed
@hius07 hius07 deleted the button-dialog-add-widget branch June 1, 2025 05:21
@sebdelsol

sebdelsol commented Jun 1, 2025

Copy link
Copy Markdown

It works great, Tx a lot.

BTW, I've tried to add a separator between the title and the widgets to no avail.

@hius07

hius07 commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

The separator property works for added widgets only.
To add a separator after the title, the LineWidget should be the first added widget.

@hius07

hius07 commented Jun 2, 2025

Copy link
Copy Markdown
Member Author

The idea is interesting, I'll think about adding the separator property to the title.
(It needs vertical spans fine tuning)

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants