improve ota updates#13888
Merged
Merged
Conversation
Member
Author
|
Speaking about OTAs, if I decide I don't want to install an update now, then I end up deadlocked on the "The update will be applied the next time KOReader is started." popup, presumably because it's created as not dismissable too?
function Device:install()
local ConfirmBox = require("ui/widget/confirmbox")
UIManager:show(ConfirmBox:new{
text = _("Update is ready. Install it now?"),
ok_text = _("Install"),
ok_callback = function()
local save_quit = function()
self:saveSettings()
UIManager:quit(85)
end
UIManager:broadcastEvent(Event:new("Exit", save_quit))
end,
cancel_text = _("Later"),
cancel_callback = function()
local InfoMessage = require("ui/widget/infomessage")
UIManager:show(InfoMessage:new{
text = _("The update will be applied the next time KOReader is started."),
unmovable = true,
dismissable = false,
})
end,
unmovable = true,
dismissable = false,
})
end |
Member
Frenzie
approved these changes
May 30, 2025
Add `--numeric-owner` for a very minor size reduction.
- use the latest stable release tag date for all files modification time - tweak tar command tar to ignore read-errors (so missing files don't result in a failure to create the installation archive)
8042941 to
29b81f1
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Increase re-use:
Version:getBuildDate()for nightlies)Comparison:
Default:
With
--mtime=2025-04-09 --numeric-owner:This change is