VocabBuilder plugin: show copy button on duplication when adding#13876
Merged
Conversation
Frenzie
reviewed
May 28, 2025
| local removable_head = _("Vocabulary exists:") .. " " | ||
| local title = self.title | ||
| if self.update_callback and title:sub(1, #removable_head) == removable_head then | ||
| title = title:sub(#removable_head + 1) |
Member
There was a problem hiding this comment.
This all feels a touch awkward? Maybe it should just add a self.word to WordInfoDialog in addition to the title?
Frenzie
approved these changes
May 28, 2025
Contributor
|
May I ask if there is a problem with merging this PR? |
Member
|
I was/am very occupied both last week and this week. But no problem in any case, just giving people time to comment. |
Contributor
Oh, I'm sorry. I didn't mean to burden you. |
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially completes #13261.
This change is