Skip to content

Added Onyx Boox Go 7 to devices that follow gravity.#13872

Merged
Frenzie merged 2 commits into
koreader:masterfrom
jadehawk:master
May 31, 2025
Merged

Added Onyx Boox Go 7 to devices that follow gravity.#13872
Frenzie merged 2 commits into
koreader:masterfrom
jadehawk:master

Conversation

@jadehawk

@jadehawk jadehawk commented May 28, 2025 •
edited by Frenzie
Loading

Copy link
Copy Markdown
Contributor

With Onyx Boox Go 7. When the device is rotated (Left Hand to Right Hand) the button function does not rotate.
need to add Onyx Boox Go 7 to list of devices that need disableRotationMap() activated.

user patch works in the meantime. On current android nightly ( v2025.04-90-g58860f65d_2025-05-27 )

local logger = require("logger")
local Device = require("device")
Device.input.rotation_map = {
    [0] = {},
    [1] = {},
    [2] = {},
    [3] = {},
}
logger.info("Hardware button rotation disabled by user patch")

<!-- Reviewable:start -->
- - -
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/koreader/koreader/13872)
<!-- Reviewable:end -->

@jadehawk jadehawk changed the title Added Onyx Boox Go 7 to devices that follow gravity. ( https://github.com/koreader/koreader/issues/9223, https://github.com/koreader/koreader/issues/12423 ) Added Onyx Boox Go 7 to devices that follow gravity. May 28, 2025
Frenzie
Frenzie reviewed May 28, 2025
View reviewed changes
Comment thread frontend/device/android/device.lua Outdated

-- disable translation for specific models, where media keys follow gravity, see https://github.com/koreader/koreader/issues/12423
if android.prop.model == "moaanmix7" or android.prop.model == "xiaomi_reader" or android.prop.model == "gocolor7" then
if android.prop.model == "moaanmix7" or android.prop.model == "xiaomi_reader" or android.prop.model == "gocolor7" or android.prop.model == "go7" then

@Frenzie Frenzie May 28, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I overlooked it last time but it should probably be alphabetical if it's growing (go7 or gocolor7 or moaanmix7 or xiaomi_reader).

@jadehawk jadehawk May 28, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Followed same order as given by Windows.

@jadehawk
Sorted in Alphabetical Order
4152988 
Sorted entries in alphabetical order for consistency.

Ref: koreader#13872

Followed Windows Sort Order.
@Frenzie Frenzie added this to the 2025.05 milestone May 28, 2025
@hugleo

hugleo commented May 30, 2025

Copy link
Copy Markdown
Contributor

Perhaps this long OR line should be better replaced by a QUIRK.

@jadehawk

jadehawk commented May 31, 2025

Copy link
Copy Markdown
Contributor Author

Perhaps this long OR line should be better replaced by a QUIRK.

Probably wrong, since I had no CLUE what a QUIRK was until you mentioned the word.

I did play around with the help of AI and on a new branch added the following changes just playing around.
However, I would like to know if I was at least a little close to what you meant.

Reference this 1 Extra file created
And the OR line removed and replaced by something like THIS

Was I even remotely close, I haven't figure out how to get the docker dev environment for KOReader working to test any of this.

@Frenzie

Frenzie commented May 31, 2025

Copy link
Copy Markdown
Member

I think that was meant on the luajit-launcher side, but something like that is what it comes down to, yes. I'll merge this as is for now since it still seems reasonable to me.

@Frenzie Frenzie merged commit a38a578 into koreader:master May 31, 2025
4 checks passed
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
@jadehawk
Added Onyx Boox Go 7 to devices that follow gravity. (koreader#13872)
c56f2aa 
(koreader#9223, koreader#12423)

* Sorted in Alphabetical Order 

Ref: koreader#13872

Followed Windows Sort Order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees

No one assigned

Labels

Android

Projects

None yet

Milestone

2025.08

Development

Successfully merging this pull request may close these issues.

3 participants

@jadehawk @hugleo @Frenzie