[DictQuickLookup] enable full-screen mode for open dictionary window by Commodore64user · Pull Request #13862 · koreader/koreader

Commodore64user · 2025-05-26T15:10:05Z

we've all been there, you look up a word definition only to realise is long AF and you ponder, why isn't there an easy way to go full screen mode here? well worry not past me... here it is.

what's new

Static Variables and Properties: Added a new static variable temp_fullscreen_request and a private property _is_temporary_fullscreen_mode to manage the temporary fullscreen state.
Gesture and Key Bindings: Introduced a new gesture (spread) and a key binding (screenkb/shift + home ) to trigger the temporary fullscreen mode.
Initialisation Logic: Updated the init method to check for temp_fullscreen_request and set the appropriate dictionary and fullscreen mode state during initialisation.
Fullscreen Mode Implementation: Added setTemporaryFullScreenMode and onSetTemporaryFullScreenMode methods to handle the logic for enabling fullscreen mode, including re-triggering lookups and managing the window_list.
Cleanup on Close: Modified the onClose method to revert the fullscreen mode setting when the widget is closed.

screen recording

This change is

poire-z

Not sure I like the playing with temporary state and restoring - and the way it is done with a module variable, but if there's no other simpler way, ok.

poire-z · 2025-05-26T15:18:44Z

            local modifier = Device:hasScreenKB() and "ScreenKB" or "Shift"
            self.key_events.ChangeToPrevDict = { { modifier, Input.group.PgBack } }
            self.key_events.ChangeToNextDict = { { modifier, Input.group.PgFwd } }
+            self.key_events.SetTemporaryFullScreenMode = { { modifier, "Home" } }


You got a big home !
(Glad to see the Home button not taking you home :))

well, we're not using home, we are using screenkb + home

poire-z · 2025-05-26T15:20:39Z

+    -- We want to remember the current dict_index (e.g. 5/7), so that it can be restored later.
+    DictQuickLookup.temp_fullscreen_request = { dict_index = self.dict_index, }
+    -- This setting will be reverted upon closing the new instance. Note that any would be child windows will also open in fullscreen mode.
+    G_reader_settings:makeTrue("dict_largewindow")


A bit dirty to play with temporary toggling a user setting. Any other way ?
(So, you're still using a small window ?)

I did think it wasn't ideal. But I couldn't come up with an idea that was as "clean" as this.

I use the patched window, thank you very much, I wanted to make it more dramatic here as the patch probably has a user base of 1 (2?)

There is also adding a full-screen = true to temp-fullscreen-request and using that instead of G-setts

poire-z · 2025-05-26T15:21:22Z

+    -- This setting will be reverted upon closing the new instance. Note that any would be child windows will also open in fullscreen mode.
+    G_reader_settings:makeTrue("dict_largewindow")
+
+    local ui_ref = self.ui or UIManager


You could call it just local ui = (every object is a ref).

poire-z · 2025-05-26T16:13:43Z

+    local ui = self.ui or UIManager
    -- Re-trigger the lookup, and close this instance _after_ the new one is created.
    if self.is_wiki then
-        ui_ref:handleEvent(Event:new("LookupWikipedia", self.word, self.is_sane_word, self.word_boxes, false, self.lang, function() self:onClose(true) end))
+        ui:handleEvent(Event:new("LookupWikipedia", self.word, self.is_sane_word, self.word_boxes, false, self.lang, function() self:onClose(true) end))
    else
-        ui_ref:handleEvent(Event:new("LookupWord", self.word, true, self.word_boxes, self.highlight, nil, function() self:onClose(true) end))
+        ui:handleEvent(Event:new("LookupWord", self.word, true, self.word_boxes, self.highlight, nil, function() self:onClose(true) end))


Btw, I'm not sure calling UIManager:handleEvent (the module itself) will work.
If there's no self.ui (and you can't find a use case where there is none), just do nothing / return if there is none.

and you can't find a use case where there is none

Well in that case is not needed then, i was being cautious in case FM would ever say, nope not having it.

poire-z · 2025-05-27T06:45:47Z

(Also, you wrote everything with the word "temp fullscreen", while it is actually just "temp large window".)

Commodore64user · 2025-06-01T18:32:07Z

Wondering if @poire-z is upset or something ;)

poire-z · 2025-06-01T19:00:28Z

No, still just busy.
There are still a lof of "fullscreen" mention, which should be "large window" (because that's what this is, and for consistency while reading, so we know all this is about templargewindow and there is not a different feature called tempfullscreen).

    _is_temporary_fullscreen_mode = false,
-- Static variable to hold request data for temporary fullscreen
DictQuickLookup.temp_fullscreen_request = nil
            SetTemporaryFullScreenMode = {
    self.temp_large_window = DictQuickLookup.temp_fullscreen_request and DictQuickLookup.temp_fullscreen_request.full_screen == true
    if DictQuickLookup.temp_fullscreen_request and DictQuickLookup.temp_fullscreen_request.dict_index then
        self:changeDictionary(DictQuickLookup.temp_fullscreen_request.dict_index, true)
        DictQuickLookup.temp_fullscreen_request.dict_index = nil
        self._is_temporary_fullscreen_mode = true
            self.key_events.SetTemporaryFullScreenMode = { { modifier, "Home" } }
function DictQuickLookup:onSetTemporaryFullScreenMode()
    self:setTemporaryFullScreenMode()
function DictQuickLookup:setTemporaryFullScreenMode()
    DictQuickLookup.temp_fullscreen_request = {
        full_screen = true, -- note: any would-be child window will also open in fullscreen mode.
    if self._is_temporary_fullscreen_mode then
        DictQuickLookup.temp_fullscreen_request = nil

benoit-pierre · 2025-06-01T19:32:23Z

Maybe "maximized" would be a better term.

poire-z · 2025-06-01T19:34:44Z

But this PR just temporarily enable the existing "large window" display, it does not need a new word :)

…early beter but whatever

poire-z · 2025-06-02T10:36:52Z

+    -- We want to remember the current dict_index (e.g. 5/7), so that it can be restored later.
+    DictQuickLookup.temp_large_window_request = {
+        dict_index = self.dict_index,
+        full_screen = true, -- note: any would-be child window will also open in fullscreen mode.


Does this one needs to be named full_screen, althought being part of a table named temp_large_window_request ?

you are something else ;)

Commodore64user · 2025-12-07T21:59:59Z

kindle added a similar feature to this one in 5.18.6, not claiming or suggesting this PR was their inspiration, but it looks a bit sus ;)

their implementation is a bit rubbish though. ¯\_(ツ)_/¯

…indow (koreader#13862)

Commodore64user added 2 commits May 25, 2025 16:24

allow dict window to go full screen

9cebe88

change method name and reword some comments

94d9b21

poire-z reviewed May 26, 2025

View reviewed changes

rename ui_ref to just ui

f9b21e9

poire-z reviewed May 26, 2025

View reviewed changes

don't muck about with G_settings

546c70c

rename var

8e70f9b

use @poire-z's ridiculous large_window name ;), fullscreen mode is cl…

e50e652

…early beter but whatever

poire-z reviewed Jun 2, 2025

View reviewed changes

rename once again

a1477d0

poire-z approved these changes Jun 2, 2025

View reviewed changes

Frenzie added this to the 2025.05 milestone Jun 2, 2025

Frenzie merged commit 06661b0 into koreader:master Jun 2, 2025
2 of 4 checks passed

Commodore64user deleted the full-screen-dict branch June 2, 2025 13:26

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026

[DictQuickLookup] Enable temporary large window for open dictionary w…

2cc6a22

…indow (koreader#13862)

Uh oh!

Uh oh!

Conversation

Commodore64user commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

what's new

screen recording

Uh oh!

poire-z left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

poire-z commented May 27, 2025

Uh oh!

Commodore64user commented Jun 1, 2025

Uh oh!

poire-z commented Jun 1, 2025

Uh oh!

benoit-pierre commented Jun 1, 2025

Uh oh!

poire-z commented Jun 1, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Commodore64user commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Commodore64user commented May 26, 2025 •

edited

Loading

Commodore64user commented Dec 7, 2025 •

edited

Loading