Add tests for NewsDownloader#13806
Merged
Merged
Conversation
Frenzie
commented
May 16, 2025
|
|
||
| describe("RSS feed parsing", function() | ||
| local rss_xml = [[ | ||
| <?xml version="1.0" encoding="UTF-8" ?> |
Member
Author
There was a problem hiding this comment.
Disclaimer: Copilot wrote the bulk of these fake feeds and even some of these tests, which might be testing things that verge too much into implementation details, such as feeds.rss.channel.item[1].title. I'll have to do another pass wrt that.
dba6960 to
0da9f6e
Compare
0da9f6e to
1cc7fa4
Compare
To help prevent situations like koreader#13799. As also referenced in <koreader#13407 (comment)>. Also fixes single item RSS and single entry Atom feeds in passing. References koreader#3073.
1cc7fa4 to
7c16c57
Compare
Frenzie
added a commit
to Frenzie/koreader
that referenced
this pull request
Jun 13, 2025
Accidentally changed in koreader#13806. Closes koreader#13933.
Frenzie
added a commit
that referenced
this pull request
Jun 13, 2025
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
To help prevent situations like koreader#13799. As also referenced in <koreader#13407 (comment)>. Also fixes single item RSS and single entry Atom feeds in passing. References koreader#3073.
0xstillb
pushed a commit
to 0xstillb/koreader-thai
that referenced
this pull request
May 9, 2026
Accidentally changed in koreader#13806. Closes koreader#13933.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To help prevent situations like #13799.
As also referenced in #13407 (comment).
Also fixes single item RSS and single entry Atom feeds in passing.
References #3073.
This change is