Key press handlers to show upper menu#13511
Conversation
|
I am afraid you are still passing the event object as |
|
Did you test? Looks okay: koreader/frontend/apps/filemanager/filemanagermenu.lua Lines 1110 to 1112 in edd1ed8 |
|
Maybe because of koreader/plugins/hotkeys.koplugin/main.lua Line 517 in 68f3b34 |
I am embarrassed to say, you are right. that's the problem. |
|
On second thought, shouldn't that |
|
I'm not necessarily jumping for joy at the thought of removing an event handler. Could you clarify that? |
|
No one is directly calling it anymore. Is what i was going to say, before realising that dispatcher still uses it. Never mind |
Closes #13507.
This change is