File browser: filter by status#13503
Conversation
|
Usage hint: long-pressing on the "Book status: ..." menu item resets the filter to "all". "All" does not check (and fetch) book statuses. |
|
(Not a user of this feature, no strong opinion, just a little feeling that showing some status or some others is more of a one-shot decision for the current browsing session, than a full sticky filebrowser setting, so more something I would expect from the plus menu. But in History, we have it in the hamburger menu, and it sticks. Also probably more complicated to do it from elsewhere than just replacing show_finished.) |
|
I thought about the Plus menu. |
|
In History and Collections the popup dialog is the only way to call actions (I thought about the upper touch menu, looks rather complicated). |
| -- maintain a reference to menu_container | ||
| self.menu_container = menu_container | ||
| if not do_not_show then | ||
| if do_not_show ~= true then -- Menu search does not open the menu when called by a gesture |
There was a problem hiding this comment.
Although this partially solves #13507 (currently only fixing FM but not reader), shouldn’t this be fixing the fact that random things are being passed as arguments instead?
There was a problem hiding this comment.
Agree, let's discuss and fix it separately.
This change is