Skip to content

Dispatcher: fix action deleted arg#13488

Merged
hius07 merged 4 commits into
koreader:masterfrom
hius07:dispatcher-deleted-actions
Apr 5, 2025
Merged

Dispatcher: fix action deleted arg#13488
hius07 merged 4 commits into
koreader:masterfrom
hius07:dispatcher-deleted-actions

Conversation

@hius07

@hius07 hius07 commented Mar 30, 2025

Copy link
Copy Markdown
Member

Font file or user style tweak can be deleted (outside of the program) after assigning an action with them as arg.
Fix displaying the action in Gesture manager / Profiles.
Check for font/tweak existence before executing.
Closes #13479.


This change is Reviewable

@hius07

hius07 commented Mar 30, 2025

Copy link
Copy Markdown
Member Author

@poire-z minor nits in tweak id - a space at the end. Fixing will break users' settings.

id = "titles_page-break-before_avoid ",

id = "docfragment_page-break-before_avoid ",

id = "publisher_page-breaks_avoid ",

@poire-z

poire-z commented Mar 30, 2025

Copy link
Copy Markdown
Contributor

Oh, sorry for that :/
What would happen if we fix these, and users have them with spaces ? Crash or just not effect ? (These must be quite rarely used/enabled, and it will probably noticed if they were needed but have no longer effect.)

@hius07

hius07 commented Mar 30, 2025

Copy link
Copy Markdown
Member Author

With this PR, just no effect.

@mergen3107

Copy link
Copy Markdown
Contributor

@poire-z minor nits in tweak id - a space at the end. Fixing will break users' settings.

id = "titles_page-break-before_avoid ",

id = "docfragment_page-break-before_avoid ",

id = "publisher_page-breaks_avoid ",

Can’t one-time migration help?

@hius07 hius07 merged commit 0a9169e into koreader:master Apr 5, 2025
@hius07 hius07 deleted the dispatcher-deleted-actions branch April 5, 2025 06:50
@hius07 hius07 added this to the 2025.03 milestone Apr 5, 2025
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: "bad argument #2 to 'format' error in dispatcher.lua:653 when using double tap function

3 participants